Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor DROP TABLE and DROP PROCEDURE calls in test code #222

Merged
merged 3 commits into from
Mar 31, 2017
Merged

refactor DROP TABLE and DROP PROCEDURE calls in test code #222

merged 3 commits into from
Mar 31, 2017

Conversation

gordthompson
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 25, 2017 •
edited
Loading

Codecov Report

Merging #222 into dev will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #222      +/-   ##
============================================
- Coverage     32.91%   32.78%   -0.13%     
+ Complexity     1437     1433       -4     
============================================
  Files            97       97              
  Lines         23385    23385              
  Branches       3889     3889              
============================================
- Hits           7697     7667      -30     
- Misses        14140    14174      +34     
+ Partials       1548     1544       -4
Flag Coverage Δ Complexity Δ
#JDBC41 32.7% <ø> (-0.01%) 1430 <ø> (+1)
#JDBC42 32.74% <ø> (-0.09%) 1432 <ø> (-3)
Impacted Files Coverage Δ Complexity Δ
...om/microsoft/sqlserver/jdbc/SimpleInputStream.java 38.23% <0%> (-1.48%) 9% <0%> (-1%)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java 36.23% <0%> (-0.63%) 0% <0%> (ø)
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java 23.56% <0%> (-0.37%) 168% <0%> (-3%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java 45.01% <0%> (-0.08%) 182% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5293f28...d673438. Read the comment docs.

v-nisidh
v-nisidh reviewed Mar 27, 2017
View reviewed changes
src/test/java/com/microsoft/sqlserver/testframework/Utils.java Outdated
"DROP %s %s ",
bracketedObjectName,
objectProperty,
objectProperty == "IsProcedure" ? "PROCEDURE" : "TABLE",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think

"IsProcedure".equalsIgnore(objectProperty) ? "PROCEDURE" : "TABLE";
or
"IsProcedure".equals(objectProperty) ? "PROCEDURE" : "TABLE";

will be more appropriate.

@gordthompson
Copy link
Contributor Author

@v-nisidh - Of course. Thanks for catching it.

@v-nisidh v-nisidh merged commit 304acab into microsoft:dev Mar 31, 2017
@gordthompson gordthompson deleted the cleanup-object-drops branch March 31, 2017 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-nisidh v-nisidh v-nisidh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gordthompson @codecov-io @v-nisidh